-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single page app #3
Conversation
…ales into refactoring-ui
Apply Sweep Rules to your PR?
|
🚀 Expo preview is ready!
|
|
e5dfcc0
to
8f3f01c
Compare
bc0e841
to
0fd89d7
Compare
@sutyum sir add comments in the code, wherever you feel something is lacking, will fix it first thing in morning |
is it working? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is looking fine for what is needed here, as long as it works. I have avoided adding unnecessary improvements that you can make as we need to ship this fast and move to ella
name="info-circle" | ||
size={25} | ||
color={Colors[colorScheme ?? "light"].text} | ||
className={`mr-15 ${ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -10,7 +10,7 @@ export default function NotFoundScreen() { | |||
<View className="flex-1 items-center justify-center p-5"> | |||
<Text className="text-2xl font-bold">This screen doesn't exist.</Text> | |||
|
|||
<Link href="/index" className="mt-4 py-4"> | |||
<Link href="/" className="mt-15 py-15"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sort of styling will break on various screens, consider using auto margins instead
import { openDatabaseSync } from "expo-sqlite/next"; | ||
import path from "path"; | ||
|
||
import { callLogs, tasks } from "./schema"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'tasks' is defined but never used
@@ -6,6 +6,9 @@ const config = getDefaultConfig(__dirname, { | |||
// [Web-only]: Enables CSS support in Metro. | |||
isCSSEnabled: true, | |||
}); | |||
|
|||
config.resolver.sourceExts.push("sql"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
react-native-call-log.d.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Nope, we figured out way to configure dual databases, and called sync function
|
@sutyum sir please guide on work ahead |
Tech stack
##Process
@sutyum sir update this, so it will be clear to me and will help me to learn