webrtc-adapter dependency to npm dependency from git submodule #283
Conversation
|
I opened this pull request yesterday, but did a hard reset on master and force pushed so the old pull request got closed automatically. These changes are on the development branch now. |
|
@letchoo LGTM. |
| }, | ||
|
|
||
| version: '<%= pkg.version %>-<%= githash.submodule.short %>', | ||
| version: '<%= pkg.version %>', |
There was a problem hiding this comment.
Well, we would no longer be depending on a git-hash, but rather a node dep' version...
If anything, then what we should put next to our version number would be the webrtc-adapter version number.
I'm not sure if that's worth it though...
There was a problem hiding this comment.
I don't see it's necessary as well if we are relying on the npm dependency version, but since this might change our release tagging process a bit, its be better we reconfirm with @ncurrier on this.
There was a problem hiding this comment.
I'm ok with the version being specified in the package.json as long as it explicitly specified and does not rely on ranges. This PR specifies any minor release greater than 2.0.3 (^2.0.3), that I am not ok with.
@johache are you comfortable with only sticking to published releases? That does limit us slightly from previously where its commit based, however that may not be an issue and the simplicity may be favored.
There was a problem hiding this comment.
I'm fine with this limitation. We can always revert in the future if we realise this is completely blocking for us.
It does sound safer to only use released version anyway. It means that it passed Google's safety checks.
@NTARelix , could you change your PR so that it uses a specific version rather than a compatible one ? (2.0.3 instead of ^2.0.3)
AdapterJS depends on webrtc/adapter (webrtc-adapter on npm). We currently declare this dependency via git submodules when ideally it would be in package.json. There are multiple reasons for this (one of which I've run into with bug #262, as well as being unable to install this dependency in a minimal CI slave that doesn't have git).
The build involves hooking into the npm lifecycle (see postinstall in package.json) to build this webrtc-adapter dependency before injecting it into this package's output. I've removed the submodule in favor of a pre-built npm dependency.