Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle_sync_stree_demo #54

Open
wants to merge 3 commits into
base: KonaFiber
Choose a base branch
from
Open

Oracle_sync_stree_demo #54

wants to merge 3 commits into from

Conversation

itwaix
Copy link

@itwaix itwaix commented Aug 2, 2021

Operate against Oracle database, use kona

@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shiyuexw shiyuexw requested a review from huishi-hs August 5, 2021 08:23
@huishi-hs
Copy link
Collaborator

Thanks for your PR! This is good step for us.

there are already two database related demo, one is mysql and another is iotdb(Time Series Database). Oracle test should be similar with mysql and my comment is keep demos not duplicate.

would like see others fiber application from you.

Java compilation lacks suffix
@@ -1,5 +1,5 @@
test steps:
1. javac VTSleepStress
1. javac VTSleepStress.java
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs be a separate PR. not related with Oracle_sync_stree_demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants