-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drawer): 传入 confirmBtnProps
和 cancelButtonProps
可分别自定义按钮
#2416
Open
peng-yin
wants to merge
1
commit into
Tencent:develop
Choose a base branch
from
peng-yin:feat/drawer_btn_props
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import React, { useState } from 'react'; | ||
import { Drawer, Button } from 'tdesign-react'; | ||
|
||
export default function () { | ||
const [visible, setVisible] = useState(false); | ||
|
||
const handleClick = () => { | ||
setVisible(true); | ||
}; | ||
const handleClose = () => { | ||
setVisible(false); | ||
}; | ||
return ( | ||
<> | ||
<Button theme="primary" onClick={handleClick}> | ||
打开抽屉 | ||
</Button> | ||
<Drawer | ||
header="抽屉标题" | ||
visible={visible} | ||
onClose={handleClose} c | ||
cancelBtnProps={{ disabled: true }} | ||
confirmBtnProps={{ disabled: true }} | ||
cancelBtn={'取消'} | ||
> | ||
<p>抽屉的内容</p> | ||
</Drawer> | ||
</> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue的意思是cancelBtn没有支持Object类型 不需要增加API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我是这样认为的, cancelBtn如果支持Object类型的话, 会使代码冗余,增加判断条件, 而且参数也不语义化, 所以cancelButton 的props 应该和 cancelButton TNode分开
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里主要有两个问题 一个是这个要录到API平台来统一管理 一个是目前1.0版本的设计是这样子 涉及类似设计的组件比较多 不能单独为这一个组件改动API 这样和其他组件也不是很一致了 所以会比较希望这种大优化放在2.0版本然后一起调整一下 同步在这里下