test(affix): improve Affix component and tests #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- optimize environment judgment - correctly judge whether parameters are passed in
RSS1102
requested review from
honkinglin,
uyarn,
carolin913,
HaixingOoO,
NWYLZW and
ZWkang
as code owners
|
|
|
This comment was marked as outdated.
This comment was marked as outdated.
uyarn
reviewed
Dec 23, 2024
| @@ -102,7 +102,7 @@ const Affix = forwardRef<AffixRef, AffixProps>((props, ref) => { | |||
| }); | |||
| } | |||
| ticking.current = true; | |||
| }, [classPrefix, offsetBottom, offsetTop, onFixedChange, zIndex]); | |||
| }, [classPrefix, offsetBottom, offsetTop, onFixedChange, props?.offsetBottom, props.offsetTop, zIndex]); | |||
There was a problem hiding this comment.
不建议这样写dep , 另外这样子为什么就达到了修复判断距离容器位置参数是否传入的效果？
There was a problem hiding this comment.
我被 eslint 提示这样传入 dep。
修复的原因在之前写了不小心 hide 了 现在恢复了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
test(affix): 添加测试用例并修复判断距离容器位置参数是否传入
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单