Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(descriptions): layout="vertical" mode, slot title error #4707

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Nov 1, 2024

test(descriptions): add a test of title slot in layout="vertical" mode

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

follow #4656

💡 需求背景和解决方案

📝 更新日志

  • fix(Descriptions): 修复了在 layout="vertical" 模式下,使用 title 插槽渲染错误的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RSS1102
Copy link
Contributor Author

RSS1102 commented Nov 1, 2024

直接 props 可选处理一下吧
然后要是能把类型加上的话也加一下

@zhangpaopao0609 能麻烦有空的时候给看下嘛。

示例也加一下

示例的话估计要让 @uyarn 那边来决定如何添加。

Copy link
Contributor

github-actions bot commented Nov 1, 2024

完成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant