Remove useless code

Tencent · Oct 24, 2024 · 617b5a0 · 617b5a0
1 parent 88095f6
commit 617b5a0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 31 deletions.
diff --git a/src/common/core/InnerDatabase.cpp b/src/common/core/InnerDatabase.cpp
@@ -645,12 +645,6 @@ void InnerDatabase::tryLoadIncremetalMaterial()
     if (!m_needLoadIncremetalMaterial) {
         return;
     }
-    auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_incremental_backup");
-    if (config.failed() || config.value().length() == 0
-        || atoi(config.value().data()) != 1) {
-        m_needLoadIncremetalMaterial = false;
-        return;
-    }
 
     const StringView &databasePath = getPath();
     StringView materialPath

diff --git a/src/common/core/operate/OperationQueue.cpp b/src/common/core/operate/OperationQueue.cpp
@@ -524,11 +524,6 @@ void OperationQueue::asyncCheckpoint(const UnsafeStringView& path)
         Operation operation(Operation::Type::Checkpoint, path);
         Parameter parameter;
         double checkPointInterval = OperationQueueTimeIntervalForCheckpoint;
-        auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_checkpoint_interval");
-        if (config.valueOrDefault().length() > 0) {
-            checkPointInterval = std::max(checkPointInterval, atof(config->data()));
-            checkPointInterval = std::min(checkPointInterval, 600.0);
-        }
         async(operation, checkPointInterval, parameter, AsyncMode::ForwardOnly);
     }
 }

diff --git a/src/common/repair/factory/FactoryBackup.cpp b/src/common/repair/factory/FactoryBackup.cpp
@@ -59,21 +59,16 @@ bool FactoryBackup::work(const UnsafeStringView& database, bool interruptible)
 bool FactoryBackup::doBackUp(const UnsafeStringView& database, bool interruptible)
 {
     Optional<size_t> incrementalMaterialSize = 0;
-    auto config = CommonCore::shared().getABTestConfig("clicfg_wcdb_incremental_backup");
-    bool incrememtalBackupEnable = config.succeed() && config.value().length() > 0
-                                   && atoi(config.value().data()) == 1;
     SharedIncrementalMaterial incrementalMaterial;
-    if (incrememtalBackupEnable) {
-        incrementalMaterial = CommonCore::shared().tryGetIncrementalMaterial(database);
-        if (interruptible && incrementalMaterial != nullptr) {
-            incrementalMaterialSize = saveIncrementalMaterial(database, incrementalMaterial);
-            if (!incrementalMaterialSize.hasValue()) {
-                return false;
-            }
-            if (Time::now().seconds() - incrementalMaterial->info.lastBackupTime < OperationQueueTimeIntervalForBackup
-                && incrementalMaterial->pages.size() < BackupMaxIncrementalPageCount) {
-                return true;
-            }
+    incrementalMaterial = CommonCore::shared().tryGetIncrementalMaterial(database);
+    if (interruptible && incrementalMaterial != nullptr) {
+        incrementalMaterialSize = saveIncrementalMaterial(database, incrementalMaterial);
+        if (!incrementalMaterialSize.hasValue()) {
+            return false;
+        }
+        if (Time::now().seconds() - incrementalMaterial->info.lastBackupTime < OperationQueueTimeIntervalForBackup
+            && incrementalMaterial->pages.size() < BackupMaxIncrementalPageCount) {
+            return true;
         }
     }
 
@@ -103,12 +98,10 @@ bool FactoryBackup::doBackUp(const UnsafeStringView& database, bool interruptibl
     }
 
     SharedIncrementalMaterial newIncrementalMaterial = backup.getIncrementalMaterial();
-    if (incrememtalBackupEnable) {
-        if (!saveIncrementalMaterial(database, newIncrementalMaterial).hasValue()) {
-            return false;
-        }
-        CommonCore::shared().tryRegisterIncrementalMaterial(database, newIncrementalMaterial);
+    if (!saveIncrementalMaterial(database, newIncrementalMaterial).hasValue()) {
+        return false;
     }
+    CommonCore::shared().tryRegisterIncrementalMaterial(database, newIncrementalMaterial);
 
     if (interruptible) {
         notifiyBackupEnd(

diff --git a/src/objc/tests/repair/common/BackupTestCase.mm b/src/objc/tests/repair/common/BackupTestCase.mm
@@ -47,7 +47,6 @@ - (void)setUp
 {
     [super setUp];
     self.objectCount = 100;
-    [WCTDatabase setABTestConfigWithName:@"clicfg_wcdb_incremental_backup" andValue:@"1"];
 }
 
 - (NSMutableArray<NSObject<RepairTestObject>*>*)objects