feat: CLB Excel导入-创建四层监听器 --story=119589495 #1074
Open
+1,118
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KooKouse
changed the title
KooKouse
force-pushed
the
github/feat-excel-listener-layer4
branch
from
5482164
to
437b3e9
Compare
KooKouse
force-pushed
the
github/feat-excel-listener-layer4
branch
from
60752c6
to
5756fb6
Compare
KooKouse
force-pushed
the
github/feat-excel-listener-layer4
branch
from
5756fb6
to
066ad74
Compare
KooKouse
force-pushed
the
github/feat-excel-listener-layer4
branch
from
f18e080
to
c4b0712
Compare
KooKouse
force-pushed
the
github/feat-excel-listener-layer4
branch
from
b33e8f2
to
ceac23a
Compare
ZQHcode
reviewed
Oct 12, 2024
cmd/cloud-server/logics/load-balancer/create_layer4_listener_executor.go
Outdated
Show resolved
Hide resolved
| return c.details, nil | ||
| } | ||
|
|
||
| const createLayer4ListenerExcelTableLen = 7 |
There was a problem hiding this comment.
默认输入的长度为7
加上用户备注的长度为8
77行这里处理了数据填写不全的情况，避免出现数组越界的问题
| default: | ||
| return fmt.Errorf("HealthCheck: invalid input: %s", data[6]) | ||
| } | ||
| if len(data) > createLayer4ListenerExcelTableLen { |
There was a problem hiding this comment.
这个是大于的判断，如果用户填写了 用户备注，则会把它记录进去。
fxdgg
reviewed
Oct 12, 2024
| return err | ||
| } | ||
| if rule == nil { | ||
| logs.Errorf("loadbalancer(%s) listener(%s) exist, but url rule not found", |
There was a problem hiding this comment.
日志需要加上rid，而且不建议在日志开头使用变量，“loadbalancer(%s) listener(%s) exist”，不利于排查问题时的日志检索呢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.