This repository has been archived by the owner on May 31, 2023. It is now read-only.
Modernify #1
Open
Modernify #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Why? I've been experimenting with upgrading to Yarn 3 for TerriaMap and terriajs. And Yarn 3 doesn't like this git dependency with a package-lock.json. Also I wanted to experiment with Yarn 3 PnP. For TerriaMap we'd likely use the node-modules linker, so it'd be very similar to yarn 1, but with performance improvements and ongoing bug fixes.
I'll probably also change this to use node-modules linker too, but leave a comment in the readme that it works with Yarn PnP (there's no need to have tiny dependencies use faster workflows like Yarn PnP, we hardly work with them).