-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated DeveloperFixed test for alibaba-druid #1289
base: main
Are you sure you want to change the base?
Conversation
What evidence do you have that |
Found the fixed commit using the git blame for file. Not being able to run the nondex build for the earlier commit as build fails due to jdk 1.6 version issue. |
I'm not convinced that this commit fixed this test. I don't understand the comment about 1.6. You'd need a stronger justification. |
The nondex tool does not work for jdk 6 and the commit with the fix was using jdk 6 . So when i try to build the project and run nondex command it gives me an error as nondex does not support jdk 6. |
How can you claim that this specific commit fixes the test if you can't compile and run the code in that commit? Also, is the commit that you're adding in the notes after the commit that was reported? I don't remember if NonDex ever supported Java 6. Maybe you can try an older version of NonDex, e.g., |
Any progress on this case? You can even change |
I am trying to figure out the commit which might have fixed it using git bisect as the one mentioned in the pr seems to be not fixing it . |
For bisect, you may consider the script from https://github.com/TestingResearchIllinois/idoft/tree/main/auto-check-fix-commit It may help you go faster, or it may slow down (or it may make you equally fast, so I fully cover all the cases :). |
I'm still waiting for a reply here. We can close this PR for negative "points", or you can provide more info (especially logs). In particular, if you can learn how to run |
I had discussed with you this in class where i tried running auto check
commit but it didn’t work for me. I am fine with closing the pr as i spent
some time on it but was not able to get anything.
…On Sat, 9 Nov 2024 at 11:58, darko-marinov ***@***.***> wrote:
I'm still waiting for a reply here. We can close this PR for negative
"points", or you can provide more info (especially logs). In particular, if
you can learn how to run git bisect, you may even present that in the
class. You can ask @wtrzas2 <https://github.com/wtrzas2> for some help.
—
Reply to this email directly, view it on GitHub
<#1289 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AM6JLB4IK6QNGIXNYKSH4TTZ7ZEMHAVCNFSM6AAAAABPX2RO26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGMZTMMRWGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Repo - https://github.com/alibaba/druid
Test - com.alibaba.druid.bvt.pool.DruidDataSourceTest_exceptionSorter.test_event_error
Developer Fixed Commit - alibaba/druid@b2fcc80