Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DeveloperFixed test for alibaba-druid #1289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yugvajani
Copy link

Repo - https://github.com/alibaba/druid
Test - com.alibaba.druid.bvt.pool.DruidDataSourceTest_exceptionSorter.test_event_error
Developer Fixed Commit - alibaba/druid@b2fcc80

@darko-marinov
Copy link
Contributor

What evidence do you have that b2fcc80e2ef70c7abf08676426d933569645897f fixed the test? Do you have logs from running right before and right after this commit?

@yugvajani
Copy link
Author

Found the fixed commit using the git blame for file. Not being able to run the nondex build for the earlier commit as build fails due to jdk 1.6 version issue.

@darko-marinov
Copy link
Contributor

I'm not convinced that this commit fixed this test. I don't understand the comment about 1.6. You'd need a stronger justification.

@yugvajani
Copy link
Author

The nondex tool does not work for jdk 6 and the commit with the fix was using jdk 6 . So when i try to build the project and run nondex command it gives me an error as nondex does not support jdk 6.

@darko-marinov
Copy link
Contributor

How can you claim that this specific commit fixes the test if you can't compile and run the code in that commit? Also, is the commit that you're adding in the notes after the commit that was reported? I don't remember if NonDex ever supported Java 6. Maybe you can try an older version of NonDex, e.g., edu.illinois:nondex-maven-plugin:1.0.0.

@darko-marinov
Copy link
Contributor

Any progress on this case? You can even change pom.xml to see if the project could compile and run tests with Java 8.

@yugvajani
Copy link
Author

I am trying to figure out the commit which might have fixed it using git bisect as the one mentioned in the pr seems to be not fixing it .

@darko-marinov
Copy link
Contributor

For bisect, you may consider the script from https://github.com/TestingResearchIllinois/idoft/tree/main/auto-check-fix-commit It may help you go faster, or it may slow down (or it may make you equally fast, so I fully cover all the cases :).

@darko-marinov
Copy link
Contributor

I'm still waiting for a reply here. We can close this PR for negative "points", or you can provide more info (especially logs). In particular, if you can learn how to run git bisect, you may even present that in the class. You can ask @wtrzas2 for some help.

@yugvajani
Copy link
Author

yugvajani commented Nov 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants