week4 update idoft - xinyinglyu #1464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 17, 2024 21:33
…ess4.md, fixing previous issues
darko-marinov
requested changes
Nov 9, 2024
| @@ -4050,7 +4050,7 @@ https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b8756361 | |||
| https://github.com/fluent/fluent-logger-java,da14ec349bf0904da9865940b57b87563616ee04,.,org.fluentd.logger.TestFluentLogger.testReconnection,NDOD;UD;NOD,Unmaintained,,last commit on 2019-06-12 | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-engine,net.redpipe.engine.swagger.SwaggerApiTest.checkSwagger,NOD,RepoArchived,, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkMail,NOD,RepoArchived,, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,Opened,https://github.com/fromage/redpipe/pull/56, | |||
| https://github.com/fromage/redpipe,0aff891d6befdf0dcc2bdbfda22262cdf82ac66f,redpipe-templating-freemarker,net.redpipe.templating.freemarker.ApiTest.checkTemplateNegociationDefault,ID,Skipped,https://github.com/FroMage/redpipe/commit/2fc605bc2fad4aadbb3b05282f528a05673df2ca#diff-86139da6bd888a5e7589f89d4f81a426bac99cd8aabab363efb5e338c1158f5bR131, | |||
There was a problem hiding this comment.
Please leave Opened as it was and put RepoArchived in the last column (Notes).
| @@ -5451,7 +5451,7 @@ https://github.com/pippo-java/pippo,ae898b6c478af7365b04c2f5bf9331abf496b166,pip | |||
| https://github.com/pippo-java/pippo,ae898b6c478af7365b04c2f5bf9331abf496b166,pippo-session-parent/pippo-session-mongodb,ro.pippo.session.mongodb.MongoDBSessionDataStorageTest.testSave,NOD,,, | |||
| https://github.com/pmd/pmd,bdc08e44fd92380d59cdc50cf9d8dd36e537c369,pmd-core,net.sourceforge.pmd.lang.rule.internal.LatticeRelationTest.testToString,ID,Opened,https://github.com/pmd/pmd/pull/4752, | |||
| https://github.com/pmd/pmd,bdc08e44fd92380d59cdc50cf9d8dd36e537c369,pmd-core,net.sourceforge.pmd.renderers.SummaryHTMLRendererTest.testRendererMultiple,ID,Accepted,https://github.com/pmd/pmd/pull/4750, | |||
| https://github.com/ppiastucki/recast4j,01d478e190b731d2fe861e3b969b4c8dd04f0ede,detourtilecache,org.recast4j.detour.tilecache.TileCacheTest.testPerformance,NOD,,, | |||
| https://github.com/ppiastucki/recast4j,01d478e190b731d2fe861e3b969b4c8dd04f0ede,detourtilecache,org.recast4j.detour.tilecache.TileCacheTest.testPerformance,NOD,MovedToGradle,, | |||
There was a problem hiding this comment.
Add in the last column the commit when the project moved to Gradle.
| https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit-adapters/rxjava,retrofit2.adapter.rxjava.SingleThrowingTest.responseThrowingInOnSuccessDeliveredToPlugin,NDOD;NOD,,, | ||
| https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit,retrofit2.CallTest.cancelOkHttpRequest,NOD,,, | ||
| https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit,retrofit2.CallTest.cancelRequest,NDOD;NOD,,, | ||
| https://github.com/square/retrofit,ae28c3d5f6fe54f6ca409cdf82106efb47609f8f,retrofit-adapters/rxjava,retrofit2.adapter.rxjava.CancelDisposeTest.cancelDoesNotDispose,NOD,MovedToGradle,, |
There was a problem hiding this comment.
As above -- add commits when the project moved to Gradle. Did you try to run this project with the NonDex Gradle plugin?
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.retry.RetryTest.shouldRetryForAtMostMaxRetriesTimes,NOD,,, | ||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.url.UrlResolutionTest.shouldAppendUrl,NOD,,, | ||
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-backup,org.zalando.riptide.backup.BackupRequestPluginTest.shouldUseBackupRequest,NOD,,, | ||
| https://github.com/zalando/riptide,dcf4af17abfd312243897e79e0577d1e28537e7d,riptide-spring-boot-autoconfigure,org.zalando.riptide.autoconfigure.CircuitBreakerTest.shouldAutowireCircuitBreakers,NOD,Skipped,, |
There was a problem hiding this comment.
You should have Skipped here. Please remove (or revise) these changes.
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginCircuitBreakerTest.shouldOpenCircuit,UD,,, | ||
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginRetriesTest.shouldInvokeListenersOnRetryableResult,UD,,, | ||
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.FailsafePluginRetriesTest.shouldNotRetryNonIdempotentMethod,UD,,, | ||
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.RetryAfterDelayFunctionTest.shouldRetryOnDemandWithDynamicDelay,NOD,,, | ||
| https://github.com/zalando/riptide,8277e11fc069d8e24df0d233ef2577cc75659b75,riptide-failsafe,org.zalando.riptide.failsafe.RetryAfterDelayFunctionTest.shouldRetryOnDemandWithDynamicDelay,NOD,Skipped,, |
There was a problem hiding this comment.
As above -- no Skipped here in IDoFT.
|
Any progress on splitting this PR into multiple? Please let me know if you need some help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing status for 28 different lines with evidences written in progress4.md