mpl2: address clang-tidy and format

Signed-off-by: Arthur Koucher <[email protected]>
The-OpenROAD-Project · Sep 26, 2024 · ede06cd · ede06cd
1 parent d5281b8
commit ede06cd
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/src/mpl2/src/SimulatedAnnealingCore.h b/src/mpl2/src/SimulatedAnnealingCore.h
@@ -142,7 +142,7 @@ class SimulatedAnnealingCore
   void calWirelength();
   void addBoundaryDistToWirelength(const T& macro,
                                    const T& io,
-                                   const float net_weight);
+                                   float net_weight);
   bool isOutsideTheOutline(const T& macro) const;
   void calGuidancePenalty();
   void calFencePenalty();

diff --git a/src/mpl2/src/clusterEngine.cpp b/src/mpl2/src/clusterEngine.cpp
@@ -369,19 +369,21 @@ Boundary ClusteringEngine::getConstraintBoundary(
     const odb::Rect& die,
     const odb::Rect& constraint_region)
 {
+  Boundary constraint_boundary = NONE;
   if (constraint_region.xMin() == constraint_region.xMax()) {
     if (constraint_region.xMin() == die.xMin()) {
-      return L;
+      constraint_boundary = L;
     } else {
-      return R;
+      constraint_boundary = R;
     }
   } else {
     if (constraint_region.yMin() == die.yMin()) {
-      return B;
+      constraint_boundary = B;
     } else {
-      return T;
+      constraint_boundary = T;
     }
   }
+  return constraint_boundary;
 }
 
 void ClusteringEngine::createIOCluster(
@@ -2110,7 +2112,7 @@ void ClusteringEngine::printPhysicalHierarchyTree(Cluster* parent, int level)
                         parent->getMacroArea());
   }
 
-   logger_->report("{}", line);
+  logger_->report("{}", line);
 
   for (auto& cluster : parent->getChildren()) {
     printPhysicalHierarchyTree(cluster.get(), level + 1);

diff --git a/src/mpl2/src/clusterEngine.h b/src/mpl2/src/clusterEngine.h
@@ -188,11 +188,11 @@ class ClusteringEngine
   Boundary getConstraintBoundary(const odb::Rect& die,
                                  const odb::Rect& constraint_region);
   void createIOCluster(const odb::Rect& die,
-                       const Boundary constraint_boundary,
+                       Boundary constraint_boundary,
                        std::map<Boundary, Cluster*>& boundary_to_cluster,
                        odb::dbBTerm* bterm);
   void setIOClusterDimensions(const odb::Rect& die,
-                              const Boundary boundary,
+                              Boundary boundary,
                               int& x,
                               int& y,
                               int& width,

diff --git a/src/mpl2/src/hier_rtlmp.cpp b/src/mpl2/src/hier_rtlmp.cpp
@@ -1007,7 +1007,7 @@ std::vector<Cluster*> HierRTLMP::getIOClusters()
 // 1) Amount of std cell area in the design.
 // 2) Extension of the IO clusters across the design's boundaries.
 float HierRTLMP::computePinAccessBlockagesDepth(
-    std::vector<Cluster*> io_clusters,
+    const std::vector<Cluster*>& io_clusters,
     const Rect& die)
 {
   float io_clusters_extension = 0.0;
@@ -3925,7 +3925,7 @@ float HierRTLMP::calculateRealMacroWirelength(odb::dbInst* macro)
       for (odb::dbITerm* iterm : net->getITerms()) {
         int x, y;
         if (iterm->getAvgXY(&x, &y)) {
-          odb::Rect iterm_rect(x, y, x , y);
+          odb::Rect iterm_rect(x, y, x, y);
           net_box.merge(iterm_rect);
         }
       }

diff --git a/src/mpl2/src/hier_rtlmp.h b/src/mpl2/src/hier_rtlmp.h
@@ -163,7 +163,7 @@ class HierRTLMP
   void setTightPackingTilings(Cluster* macro_array);
   void setPinAccessBlockages();
   std::vector<Cluster*> getIOClusters();
-  float computePinAccessBlockagesDepth(std::vector<Cluster*> io_clusters,
+  float computePinAccessBlockagesDepth(const std::vector<Cluster*>& io_clusters,
                                        const Rect& die);
   void createPinAccessBlockage(Boundary constraint_boundary,
                                float depth,