This repository has been archived by the owner on Jul 23, 2020. It is now read-only.
Cleanup, reformatting and fixes for INIClass and GameINIClass. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
OmniBlade
suggested changes
Mar 26, 2020
There was a problem hiding this comment.
I've highlighted a number of instances where asserts aren't required due to the function actually handling the condition that is being asserted, though not all of them, the asserts need reviewing and any where the variable is used and assumed to be valid need asserting, all others need removing.
Few instances where style for new lines surrounding a scope aren't being followed also need cleaning up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.