Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermediate HTML/CSS: Browser Compatibility: Correct Link Descriptive Text #28959

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

TitanTankNate
Copy link
Contributor

Because

I had not applied proper accessibility to the use of pronouns in link descriptive text during my previous PR for this issue. This PR resolves that issue while also resolving the original issue.

This PR

  • [browser_compatibility.md] Changed Line 23 link descriptive text to be more accessible

Issue

Closes #28783

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Added link to infographic video detailing the "browser wars"

Resolves issue TheOdinProject#28783
Corrected link descriptive text on Line 23 to not include "this" for
accessibility purposes
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Oct 14, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to open a new PR for changes. A PR just tracks a branch, so you just need to commit and push changes to the branch for the other PR and it'll update there.

Since this PR has already been done, I've closed that one and will merge this one.

@MaoShizhong MaoShizhong merged commit db56a19 into TheOdinProject:main Oct 14, 2024
3 checks passed
@TitanTankNate
Copy link
Contributor Author

@MaoShizhong Understood, still getting to grips with the Git process. I'll make a note of how that works: "PR tracks branch". Thanks a bunch for your patience.

@MaoShizhong
Copy link
Contributor

See #28665 for an example. It would he a nightmare is each change required a new PR :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intermediate HTML and CSS | Browser Compatibility: Add Infographic Video
2 participants