Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Routes course #28992

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

Mohamedsayhii
Copy link
Contributor

@Mohamedsayhii Mohamedsayhii commented Oct 22, 2024

Fixed a typo in the first paragraph of the Paths section, from /message/all to /messages/all since the course is referring to the paths matching:
"while /messages/all only matches if the path is /messages/all (not /messages, nor /messages/new)"

Because

message/all doesn't match messages/all so we need to change message to messages as it needs to match the next paths in the same paragraph.

This PR

  • Changed message/all to messages/all

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

Fixed a typo in the first paragraph of the Paths section, while `/message/all` to while `/messages/all` since the course is referring to the paths matching in the same phrase " while `/messages/all` only matches if the path is `/messages/all` (not `/messages`, nor `/messages/new`) "
@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label Oct 22, 2024
@MaoShizhong MaoShizhong merged commit bb277ed into TheOdinProject:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants