Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors and panics in the chirpstack v3 source #111

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

KrishnaIyer
Copy link
Member

Summary

Fix errors and panics in the chirpstack v3 source. Ref: https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1029

Changes

  • Pull Custom CA file only if CA path is set and insecure is not set.
  • Replace the deprecated grpc.WithInsecure() method.
  • Remove the ClientConn field on the Source so that the underlying one from the Config may be used.

Testing

Local with a ChirpStack v4 instance. This of course doesn't check actual migration but makes sure that the tool doesn't panic.

This will be tested by CE as a part of https://github.com/TheThingsIndustries/lorawan-stack-support/issues/1029.

Regressions

NA. This is fixing existing bugs.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.

@KrishnaIyer KrishnaIyer mentioned this pull request Feb 28, 2024
3 tasks
@KrishnaIyer KrishnaIyer merged commit e1c046f into master Mar 4, 2024
3 checks passed
@KrishnaIyer KrishnaIyer deleted the fix/chirpstack branch March 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants