Support migration from Firefly #49
Conversation
happyRip
requested review from
johanstokking and
adriansmares
as code owners
happyRip
changed the title
happyRip
force-pushed
the
feat/43-support-firefly-migration
branch
from
055d8b0
to
216881e
Compare
happyRip
force-pushed
the
feat/43-support-firefly-migration
branch
2 times, most recently
from
1f7a246
to
cba0aa6
Compare
| v3dev.Session.LastFCntUp = uint32(packet.FCnt) | ||
| } | ||
|
|
||
| if !s.config.dryRun { |
There was a problem hiding this comment.
I am inclined to instead have a --clear-keys instead. In retrospective, lots of people broke their end devices with ttnv2 by not knowing that outside of dry runs, the keys are cleared.
There was a problem hiding this comment.
Making it safe by default seems a good idea to me. --clear-keys seems to be related to the implementation, maybe something describing what's happening from a higher point of view like --disable-devices (probably some better options out there) could work as a universal solution in the future? Unless that's not the intent.
There was a problem hiding this comment.
Disable implies that it can be rolled back, which is not really the case when you delete the keys and forget to save the output (this happened many times). At least --clear-keys is equivalent to --i-really-know-what-i-am-doing.
happyRip
force-pushed
the
feat/43-support-firefly-migration
branch
from
cba0aa6
to
06a7ac8
Compare
|
What is the status here? |
|
It's blocked since we lost access to a Firefly instance. |
|
replaced by #97 |
Summary
Closes #43
Changes
fireflysourceTesting
...
Regressions
...
Notes for Reviewers
nil
Checklist
CHANGELOG.md.