squash: fix listener test data race

ThinkChaos · Aug 30, 2024 · c8eed23 · c8eed23
1 parent 8d9e373
commit c8eed23
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/service/listener_test.go b/service/listener_test.go
@@ -56,6 +56,7 @@ var _ = Describe("Service Listener", func() {
 
 			ch := make(chan struct{})
 			data := []byte("test")
+			addr := l.Addr().String() // read before starting the goroutine to avoid a race
 
 			// Server goroutine
 			go func() {
@@ -77,7 +78,7 @@ var _ = Describe("Service Listener", func() {
 
 			var conn net.Conn
 			By("connecting to server", func() {
-				conn, err = funcs.Dial(ctx, l.Addr().String())
+				conn, err = funcs.Dial(ctx, addr)
 				Expect(err).Should(Succeed())
 				DeferCleanup(conn.Close)
 			})