This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
chore: Change class and decorators locations to match new layout #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In general, ai.timefold.solver.core.api.x and its subpackages -> timefold.solver.x. - Exception for ai.timefold.solver.core.api.solver, which it and its subpackages -> timefold.solver. - ai.timefold.solver.core.x and its subpackages -> timefold.solver.x (test and config). - Use dynamic __all__ when not TYPE_CHECKING for score and domain, since they have some classes that require the JVM to be started When TYPE_CHECKING, there are stub classes that the TYPE_CHECKER will see. - Remove `@incremental_score_calculator` decorator, since it been replaced by `IncrementalScoreCalculator` ABC. - Create an empty Constraint stub so users can reference it in their type signatures without importing something from Java.
|
Where should |
triceo
reviewed
May 3, 2024
triceo
reviewed
May 3, 2024
triceo
reviewed
May 3, 2024
timefold-solver-python-core/src/main/python/heuristic/_nearby_selection.py
Show resolved
Hide resolved
triceo
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, ai.timefold.solver.core.api.x and its subpackages -> timefold.solver.x.
Exception for ai.timefold.solver.core.api.solver, which it and its subpackages -> timefold.solver.
ai.timefold.solver.core.x and its subpackages -> timefold.solver.x (test and config).
Use dynamic all when not TYPE_CHECKING for score and domain, since they have some classes that require the JVM to be started When TYPE_CHECKING, there are stub classes that the TYPE_CHECKER will see.
Remove
@incremental_score_calculatordecorator, since it been replaced byIncrementalScoreCalculatorABC.Create an empty Constraint stub so users can reference it in their type signatures without importing something from Java.