-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct typehints in project #395
Draft
yarqr
wants to merge
4
commits into
Tishka17:develop
Choose a base branch
from
yarqr:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
from typing import Union | ||
|
||
from aiogram.types import ( | ||
CallbackQuery, ChatJoinRequest, ChatMemberUpdated, Message, | ||
) | ||
from aiogram.types import CallbackQuery, ChatJoinRequest, ChatMemberUpdated, Message | ||
|
||
from .update_event import DialogUpdateEvent | ||
|
||
ChatEvent = Union[ | ||
CallbackQuery, Message, DialogUpdateEvent, | ||
ChatMemberUpdated, ChatJoinRequest, | ||
CallbackQuery, | ||
Message, | ||
DialogUpdateEvent, | ||
ChatMemberUpdated, | ||
ChatJoinRequest, | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,7 @@ | |
from aiogram.fsm.state import State | ||
|
||
from aiogram_dialog.api.exceptions import DialogStackOverflow | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we had a discussion that this is probably can be configured |
||
from .context import Context, Data | ||
|
||
DEFAULT_STACK_ID = "" | ||
|
@@ -29,7 +30,7 @@ def id_to_str(int_id: int) -> str: | |
return res | ||
|
||
|
||
def new_id(): | ||
def new_id() -> str: | ||
return id_to_str(new_int_id()) | ||
|
||
|
||
|
@@ -42,11 +43,12 @@ class Stack: | |
last_media_id: Optional[str] = field(compare=False, default=None) | ||
last_media_unique_id: Optional[str] = field(compare=False, default=None) | ||
last_income_media_group_id: Optional[str] = field( | ||
compare=False, default=None, | ||
compare=False, | ||
default=None, | ||
) | ||
|
||
@property | ||
def id(self): | ||
def id(self) -> str: | ||
return self._id | ||
|
||
def push(self, state: State, data: Data) -> Context: | ||
|
@@ -64,14 +66,14 @@ def push(self, state: State, data: Data) -> Context: | |
self.intents.append(context.id) | ||
return context | ||
|
||
def pop(self): | ||
def pop(self) -> str: | ||
return self.intents.pop() | ||
|
||
def last_intent_id(self): | ||
def last_intent_id(self) -> str: | ||
return self.intents[-1] | ||
|
||
def empty(self): | ||
def empty(self) -> bool: | ||
return not self.intents | ||
|
||
def default(self): | ||
def default(self) -> bool: | ||
return self.id == DEFAULT_STACK_ID |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,41 @@ | ||
__all__ = [ | ||
"FakeChat", "FakeUser", "ReplyCallbackQuery", | ||
"FakeChat", | ||
"FakeUser", | ||
"ReplyCallbackQuery", | ||
"DialogManagerFactory", | ||
"CALLBACK_DATA_KEY", "CONTEXT_KEY", "EVENT_SIMULATED", | ||
"STACK_KEY", "STORAGE_KEY", | ||
"ButtonVariant", "DataGetter", "InputWidget", "KeyboardWidget", | ||
"MediaWidget", "RawKeyboard", "TextWidget", "Widget", | ||
"CALLBACK_DATA_KEY", | ||
"CONTEXT_KEY", | ||
"EVENT_SIMULATED", | ||
"STACK_KEY", | ||
"STORAGE_KEY", | ||
"ButtonVariant", | ||
"DataGetter", | ||
"InputWidget", | ||
"KeyboardWidget", | ||
"MediaWidget", | ||
"RawKeyboard", | ||
"TextWidget", | ||
"Widget", | ||
"WindowProtocol", | ||
] | ||
|
||
from .fake_data import FakeChat, FakeUser, ReplyCallbackQuery | ||
from .manager import ( | ||
DialogManagerFactory, | ||
) | ||
from .manager import DialogManagerFactory | ||
from .middleware import ( | ||
CALLBACK_DATA_KEY, CONTEXT_KEY, EVENT_SIMULATED, STACK_KEY, STORAGE_KEY, | ||
CALLBACK_DATA_KEY, | ||
CONTEXT_KEY, | ||
EVENT_SIMULATED, | ||
STACK_KEY, | ||
STORAGE_KEY, | ||
) | ||
from .widgets import ( | ||
ButtonVariant, DataGetter, InputWidget, KeyboardWidget, | ||
MediaWidget, RawKeyboard, TextWidget, Widget, | ||
ButtonVariant, | ||
DataGetter, | ||
InputWidget, | ||
KeyboardWidget, | ||
MediaWidget, | ||
RawKeyboard, | ||
TextWidget, | ||
Widget, | ||
) | ||
from .window import WindowProtocol |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
from abc import abstractmethod | ||
from typing import Dict, Protocol | ||
from typing import Any, Dict, Protocol | ||
|
||
from aiogram import Router | ||
|
||
from aiogram_dialog.api.entities import ChatEvent | ||
from aiogram_dialog.api.protocols import ( | ||
DialogManager, DialogRegistryProtocol, | ||
) | ||
from aiogram_dialog.api.protocols import DialogManager, DialogRegistryProtocol | ||
|
||
|
||
class DialogManagerFactory(Protocol): | ||
@abstractmethod | ||
def __call__( | ||
self, event: ChatEvent, data: Dict, | ||
registry: DialogRegistryProtocol, | ||
router: Router, | ||
self, | ||
event: ChatEvent, | ||
data: Dict[str, Any], | ||
registry: DialogRegistryProtocol, | ||
router: Router, | ||
) -> DialogManager: | ||
raise NotImplementedError |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
original code was correct