Bugfix/issue 331 #357
Closed
Bugfix/issue 331 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Install Cypress & needed packages Update eslint config Update gitignore Add testing development mongo path * Add nock Passport.js Discord request interception * Add Cypress tests * Disable server logging when testing * Fix delay-toggling environment variable Cypress wasn't properly listening to the CYPRESS_NO_DELAYS environment variable to disable the animations waits * added modulus to getHoursAndMinutes --------- Co-authored-by: Caleb Cohen <[email protected]>
* Add timeout to GitHub actions GitHub action workflows should be limited so minutes aren't wasted if it hangs and bugs can be caught earlier. If 30 minutes isn't enough, it can be increased later on * change timeout to 10 minutes
Together-100Devs#325) * Modified app metadata to "Together is a scheduling and collaboration tool built for and by 100Devs community for creating, discovering and keeping track of events on discord." * Deleted the extra space.
* install jest and supertest * separate app and server into different files * add jest coverage folder to gitignore * allow the use of mock user in test environment * change validateBody to be a sync function * add 'use strict', fix variable declarations * extract constants * remove console logs * add mock user to db * refactor, fix validation bugs in createEventSchema * test httpError * test validateObjectId * test validateBody * refactor unit tests * export STRING_MAX_LENGTH to be used in tests * fix dotenv path to work in tests * modify mock request * test routes * refactor maxEvents middleware * add tests for maxEvents * allow event end time (not date) to be before start time * test create event with valid data * timezone bug fix: add offset to days * test createEventArray * create date range with Date instead of datefns lib * test createEventsArray in JST timezone * refactor createEventsArray and tests * fix test JST time * use Temporal to work with dates * fix event duration using Temporal * test cases for createEventsArray * test validateBody * fix acceptance tests * change hardcoded timezone to machine timezone * update test script * remove irrelevant test (maxEvents) * update front-end test * add script to run all tests together * add route tests * added formidable, jsbi, moved jest and supertest to dev dependencies --------- Co-authored-by: Caleb Cohen <[email protected]>
* Fix guest modal and and updated test * author changes and lint fix * Make time-asserting code locale-based --------- Co-authored-by: Rascal_Two <[email protected]>
…#332) * Removed delete all button from non-recurring events * Removed console.log from file
* changed description section input element to textarea element. This change added multi-line functionality and a larger textbox size. * In the input object, I changed the input element text to textarea. Cypress now reflects the changes made in the codebase for proper testing.
* feat: change eslint config to include prettier config * feat: include eslint base config in client * feat: install/configure lint-staged * chore: lint fix test * feat: install/configure husky * chore: lint fix test * --amend * lint test * add prepare script for installing husky * lint test
* delay scrolling of month by 200ms * updated calendar scrolling test to include new scroll delay. * refactor scroll month logic Changed default value of scrollMonthRef to true and reversed the conditional statement to disable scrolling while the value is false * added extra scrolling test for months --------- Co-authored-by: Caleb Cohen <[email protected]>
* lint fixes from updating prettier/lint * added prettier command, fixed some errors
…evs#345) * My testy file * Relocated CalendarPage.js * Relocate LandingPage component * fix: invalid index.css imports * chore: Remove unknown file * lint fixes --------- Co-authored-by: Trizz <[email protected]> Co-authored-by: calebco <[email protected]>
* remove border and add shadow to header button * increase padding in header
change test and added warning to windows users.
) * user is now welcomed on landingpage when logged in AuthContext is imported and the user display name is now shown on the welcome section of the landing page when a user is logged in, otherwise only the header is shown. * Removed "!" from longCard props Removed "!" from LongCard props, and moved into the ternary statement in longCard.js component where header is displayed. * Added comments to code changes * updated linting for PR 353 --------- Co-authored-by: calebco <[email protected]>
|
@gflacruz would it be possible to rebase your commit onto an up to date version of main? This is not a normal request so I'm happy to show you how to do it, it'll be a good learning experience! |
|
converted to #364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added some validation that prevents users from moving along in event creation unless dates and times are correct. Addresses situations described in #328 #329 #330.
I was unable to run test-frontend due to an error.
Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
Closes Error 400 uncaught by front-end form validation: "firstEventStart" must be greater than or equal to "now" #328 Error 500 uncaught by front-end form validation: "lastEventStart" must be [ref:firstEventStart] #329 Error 500 uncaught by front-end form validation: "endAt" should be greater than "startAt" #330 Reimplement front-end form validation #331
Checklist:
npm run testand all tests have passed successfully or I have included details within my PR on the failure. Some windows users may not be able to execute this command. Please proceed with the PR if that is the case.npm run lintand resolved any outstanding errors. Most issues can be solved by executingnpm run format