Skip to content

Commit

Permalink
Add note on confusion.
Browse files Browse the repository at this point in the history
  • Loading branch information
TomHarte committed Mar 28, 2024
1 parent 4fcb85d commit 2e7c1ac
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions InstructionSets/ARM/Executor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,14 @@ struct Executor {
}

// Decide whether to write back — when either postindexing or else write back is requested.
//
// Note to future self on write-back:
//
// It's currently unclear what to do in the case of e.g. `str r13, [r13, #0x10]!`. Is the value
// written r13 as modified or the original r13? If it's as modified, does that imply that
// write back has occurred regardless of a data abort?
//
// TODO: resolve uncertainty.
constexpr bool should_write_back = !flags.pre_index() || flags.write_back_address();

// STR: update prior to write.
Expand Down

0 comments on commit 2e7c1ac

Please sign in to comment.