Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRT: accept data during retrace. #1385

Merged
merged 3 commits into from
Jun 3, 2024
Merged

CRT: accept data during retrace. #1385

merged 3 commits into from
Jun 3, 2024

Conversation

TomHarte
Copy link
Owner

@TomHarte TomHarte commented Jun 3, 2024

The actual bug here was:

  • because the CRT doesn't display data received during periods of retrace, it would refuse to allocate space for any;
  • but, machines might still be trying to begin provision of data in that period, even if it's not actually populated or output until later;
  • ... in particular, the internal convention for outputting a single level — e.g. a border — means providing the value once and then allowing the GPU to paint it n times, so this could cause left borders in particular not to be painted, or to be painted with the wrong colour.

The particular surfacing that led me to this discovery was #1383

Resolves #1383

@TomHarte TomHarte merged commit f521c12 into master Jun 3, 2024
7 checks passed
@TomHarte TomHarte deleted the VicBorders branch June 3, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable rasters on the VIC-20
1 participant