Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pyright on Windows and MacOS #156

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Run pyright on Windows and MacOS #156

merged 1 commit into from
Dec 26, 2023

Conversation

M-DinhHoangViet
Copy link
Contributor

No description provided.

@Torom
Copy link
Owner

Torom commented Dec 26, 2023

Thanks for the PR.
At first I thought, what's the point of running pyright on different operating systems, the results should be identical. Now we see that this is not true.

I don't really understand the Winows error though, readline should not be available under Windows. I would have to start Windows and see if this is easy to fix.

@Torom Torom merged commit 9141f38 into Torom:main Dec 26, 2023
7 of 10 checks passed
@M-DinhHoangViet M-DinhHoangViet deleted the patch-1 branch December 27, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M-DinhHoangViet @Torom