Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary document file #1388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unnecessary document file #1388

wants to merge 1 commit into from

Conversation

aleksdmladenovic
Copy link
Contributor

@aleksdmladenovic aleksdmladenovic commented Oct 3, 2024 •
edited by allada
Loading

Description

Unnecessary document file of introduction/contributors.mdx is now removed.

Fixes #1387

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@aleksdmladenovic
Copy link
Contributor Author

cc: @allada, @MarcusSorealheis, @blakehatch, @SchahinRohani

aaronmondal
aaronmondal reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksdmladenovic Could you rebase this one?

+@SchahinRohani +@MarcusSorealheis

Reviewable status: 0 of 2 LGTMs obtained, and 0 of 1 files reviewed, and pending CI: NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, windows-2022 / stable (waiting on @MarcusSorealheis and @SchahinRohani)

@aleksdmladenovic
Remove unnecessary document file
3eb82b1 
Unnecessary document file of `introduction/contributors.mdx` is now
removed.
@aleksdmladenovic
Copy link
Contributor Author

Rebased changes. cc: @aaronmondal, @SchahinRohani, @MarcusSorealheis

aaronmondal
aaronmondal approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SchahinRohani

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained, and all files reviewed, and pending CI: windows-2022 / stable (waiting on @MarcusSorealheis and @SchahinRohani)

SchahinRohani
SchahinRohani approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@SchahinRohani SchahinRohani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 1 of 2 LGTMs obtained, and all files reviewed, and pending CI: windows-2022 / stable (waiting on @MarcusSorealheis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmondal aaronmondal aaronmondal approved these changes

@SchahinRohani SchahinRohani SchahinRohani approved these changes

Assignees

@MarcusSorealheis MarcusSorealheis

@SchahinRohani SchahinRohani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unnecessary document file
4 participants
@aleksdmladenovic @SchahinRohani @aaronmondal @MarcusSorealheis