Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mockup donation page #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gemaderus
Copy link

This PR implements #95.

This is still WIP, but I need some advice in order to finish it. You can see the mockup in sandbox/home-donation. Please, check the mockup and tell me what you think.

Pending:

  • Icons
  • Fine tuned responsive behaviour.
  • Integration.

I'll keep working on this with your observations :)

@furilo
Copy link
Member

furilo commented Mar 6, 2015

OK, so lots of things going on in the PR ;)

  • I don't know if you saw it, but part of the PR was already implemented (see Big banner for donation permalink #101) (but it doesn't matter a lot because of the CSS changes)
  • Some of the things of this page are not yet developed, and we don't know when/if we'll have them ;)
  • I'm seeing all the CSS changes. This is another big change which maybe we'll need a little bit of work, so maybe it should have its own PR?

cc @nobuti

@nobuti
Copy link
Contributor

nobuti commented Mar 10, 2015

The big change is my fault, I did it in #67 and she took it as reference. But imho, it's the way to go. We don't want page styles, we need modules we can repeat, abstractions to apply to different parts, in order to be able to scale without much of pain. Thoughts? Should she go on?

@furilo
Copy link
Member

furilo commented Mar 10, 2015

@nobuti I have forked your branch with the big css changes for the new things I'm doing. So once @ferblape finish with #114 and me with #112 (today I hope) we'll have your changes in master. As for this changes, I'd say we wait to release these two things and then let's see with what we should continue.

@nobuti
Copy link
Contributor

nobuti commented Mar 10, 2015

Osom!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants