Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends activity #147

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Friends activity #147

wants to merge 8 commits into from

Conversation

ferblape
Copy link

This PR implements #127

@furilo there is some work pending with the CSS:

1 - both partials which render the FB & Twitter buttons

2 - featured donations

d78838d8-cf10-11e4-99c2-93867b6f5a52

Both things are in app/views/donations/index.html.erb file:

  <% if logged_in? %>
    <% if @donations_from_everybody %>
      <% if current_user.external_service_connected? %>
        <%= render 'post_in_social_networks' %>

        <p><%= t('.donations_everybody') %></p>
      <% else %>
        <%= render 'connect_with_friends' %>
      <% end %>
    <% end %>
  <% end %>

and

  <% if @featured_donations.any? %>
    <h2><%= t('.featured_donations') %></h2>

    <% @featured_donations.each do |donation| %>
      <%= render partial: 'donation', locals: {donation: donation} %>
    <% end %>
  <% end %>

@furilo
Copy link
Member

furilo commented Apr 13, 2015

@ferblape User might have connected to one service but not the other. Maybe we should try that she links both accounts?

@ferblape
Copy link
Author

Right, I have changed it a bit, and now unless both accounts are linked the
button is shown.

On Mon, Apr 13, 2015 at 8:31 PM, Álvaro Ortiz [email protected]
wrote:

@ferblape https://github.com/ferblape User might have connected to one
service but not the other. Maybe we should try that she links both
accounts?


Reply to this email directly or view it on GitHub
#147 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants