-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request Challenge Joao Alvares Neto #3
Open
joaobbaptista
wants to merge
8
commits into
TradeRev:master
Choose a base branch
from
joaobbaptista:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 6, 2018
-
- First commit due Git problem
- MVVM Architecture - Kodein Implementation - Picasso Implementation - Retrofit and Rx implementation - webservice calling API - Responses treatment TODO - Fix bug when rotating and loading images (calling the api several times) - rename classes - fix return to same item in the previous activity - fix typos and bad codes - animation and test?
Configuration menu - View commit details
-
Copy full SHA for b6c7b8c - Browse repository at this point
Copy the full SHA b6c7b8cView commit details
Commits on May 7, 2018
-
-delete class MyTransformer - refactory -extension visibility -delete PhotoDetails - refactory -refactory DetailsActivity -Delete bind Mytransformer Kodein -change notifydataSet to NotifiyItemRange -few classes renames
Configuration menu - View commit details
-
Copy full SHA for 6336178 - Browse repository at this point
Copy the full SHA 6336178View commit details -
- onactivityforresult to maintain list
-code typos and improvements - current position list - listener scroll fix - "cache" original list
Configuration menu - View commit details
-
Copy full SHA for 4c6b8a6 - Browse repository at this point
Copy the full SHA 4c6b8a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6895c49 - Browse repository at this point
Copy the full SHA 6895c49View commit details
Commits on May 8, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3f69eba - Browse repository at this point
Copy the full SHA 3f69ebaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 18c9b5c - Browse repository at this point
Copy the full SHA 18c9b5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d96676 - Browse repository at this point
Copy the full SHA 0d96676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 922a8fd - Browse repository at this point
Copy the full SHA 922a8fdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.