Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Challenge Joao Alvares Neto #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Commits on May 6, 2018

  1. - First commit due Git problem

    - MVVM Architecture
    - Kodein Implementation
    - Picasso Implementation
    - Retrofit and Rx implementation
    - webservice calling API
    - Responses treatment
    
    TODO
    - Fix bug when rotating and loading images (calling the api several times)
    - rename classes
    - fix return to same item in the previous activity
    - fix typos and bad codes
    - animation and test?
    joaozemind committed May 6, 2018
    Configuration menu
    Copy the full SHA
    b6c7b8c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. -Add rxkotlin dependency

    -delete class MyTransformer - refactory
    -extension visibility
    -delete PhotoDetails - refactory
    -refactory DetailsActivity
    -Delete bind Mytransformer Kodein
    -change notifydataSet to NotifiyItemRange
    -few classes renames
    joaozemind committed May 7, 2018
    Configuration menu
    Copy the full SHA
    6336178 View commit details
    Browse the repository at this point in the history
  2. - onactivityforresult to maintain list

    -code typos and improvements
    - current position list
    - listener scroll fix
    - "cache" original list
    joaozemind committed May 7, 2018
    Configuration menu
    Copy the full SHA
    4c6b8a6 View commit details
    Browse the repository at this point in the history
  3. -bugfix list position

    - layout changes
    - code improvements
    joaozemind committed May 7, 2018
    Configuration menu
    Copy the full SHA
    6895c49 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2018

  1. -bugfix list position 2

    - test implementation (not functional)
    joaozemind committed May 8, 2018
    Configuration menu
    Copy the full SHA
    3f69eba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18c9b5c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0d96676 View commit details
    Browse the repository at this point in the history
  4. - bug fix detail

    joaozemind committed May 8, 2018
    Configuration menu
    Copy the full SHA
    922a8fd View commit details
    Browse the repository at this point in the history