Make FactoredMatrix
compatible with tensor-like arguments
#599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to be able to use
FactoredMatrix
with things that implement the interface oftorch.Tensor
without subclassing it. This slight change allowsFactoredMatrix
to work with such classes rather than returningNone
in various places.(I haven't finished the checklists, so creating this draft PR so I don't forget about this)
Type of change
Please delete options that are not relevant.
Checklist: