Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource manager s3 fix #935

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Resource manager s3 fix #935

merged 11 commits into from
Aug 2, 2023

Conversation

Tarraann
Copy link
Collaborator

@Tarraann Tarraann commented Aug 1, 2023

Description

Related Issues

Solution and Design

Test Plan

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tarraann seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage: 53.62% and project coverage change: -0.11% ⚠️

Comparison is base (0ceb9eb) 57.60% compared to head (1c957d7) 57.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   57.60%   57.50%   -0.11%     
==========================================
  Files         176      176              
  Lines        7464     7520      +56     
  Branches      774      779       +5     
==========================================
+ Hits         4300     4324      +24     
- Misses       2995     3028      +33     
+ Partials      169      168       -1     
Files Changed Coverage Δ
superagi/tools/file/delete_file.py 61.29% <21.42%> (-11.44%) ⬇️
superagi/helper/twitter_helper.py 52.50% <36.36%> (-2.34%) ⬇️
superagi/tools/email/send_email_attachment.py 41.55% <37.50%> (+0.71%) ⬆️
superagi/helper/github_helper.py 60.16% <50.00%> (-9.57%) ⬇️
superagi/tools/github/search_repo.py 90.90% <60.00%> (-9.10%) ⬇️
superagi/helper/s3_helper.py 100.00% <100.00%> (ø)
superagi/tools/github/add_file.py 91.42% <100.00%> (+0.51%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fluder-Paradyne Fluder-Paradyne merged commit 40a23be into main Aug 2, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants