Document support for alternative libs with tribits_tpl_find_include_dirs_and_libraries() REQUIRED_LIBS_NAMES #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IND_VERSION (TriBITSPub#610) I somehow missed this in the previous commit: 3e5471d "Change to find_package(Python3), set Python3_EXECUTABLE to PYTHON_EXECUTABLE (TriBITSPub#610)" Author: Roscoe A. Bartlett <[email protected]> Date: Thu Oct 3 12:03:52 2024 -0600 (4 weeks ago) Signed-off-by: Roscoe A. Bartlett <[email protected]>
I just noticed this when looking over this code. Signed-off-by: Roscoe A. Bartlett <[email protected]>
Signed-off-by: Roscoe A. Bartlett <[email protected]>
I was noticing that there was no hyperlinks to get from the documentation for FindTPL<tplName>.cmake to these functions and I had to resort to dumb browser searches. Signed-off-by: Roscoe A. Bartlett <[email protected]>
…_dirs_and_libraries() Signed-off-by: Roscoe A. Bartlett <[email protected]>
rabartlett1972
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds documentation for how to provide a list of alternative lib names with the
tribits_tpl_find_include_dirs_and_libraries()argumentREQUIRED_LIBS_NAMES. This has been a supported and tested feature for a long time. But amazingly, it was not documented!This PR was motivated by a question from a Trilinos user about how to update some
FindTPL<tplName>.cmakefind modules in Trilinos to look for alternative names as well (like look foropenblasif you can't findblas).Instructions to reviewers
See updated documentation. See the rendered updated documentation at: