Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Updated for issue: #638 #655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Aryan-01-star
Copy link

@Aryan-01-star Aryan-01-star commented Oct 30, 2024

Description

Under this, I have added a new glowing card feature to the website book section. I have also added multiple animations and UI improvements inside the website, leading to a better User experience (UX). Also, I have removed an error in the code and fixed the website's navbar, where some of the nav links were duplicated, and the UI was also not that appealing.

  • This PR does the following:
    • Adds: New card feature along with animations to the website
    • Fixes: Errors in the code
    • Updates: improper UI of the website's nav bar section and also to the body section of the website

Related Issues

Changes

List the detailed changes made in this PR.

  • Added a new feature to the home section of the website
  • Refactored the design for the navbar
  • Fixed a bug in the code of the entire file which was causing errors on multiple pages and was not allowing the website to run or function properly

Testing Instructions

Detailed instructions on how to test the changes. Include any setup needed and specific test cases.

  1. Pull this branch.
  2. Run npm install to install dependencies.
  3. Run the npm test to execute the test suite.
  4. Verify that ...

Screenshots (if applicable)

For navbar:
Before:
Screenshot 2024-10-31 032629
After:
image

For card:

imp.mp4

Additional Context

Any additional context or information that reviewers should be aware of?

  • This PR is based on the following...

Checklist

Make sure to check off all the items before submitting. Mark with [x] if done.

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I am working on this issue under GSSOC

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@shaurya35
Copy link
Collaborator

@Aryan-01-star why did you change /Component to /component In every file?

@Aryan-01-star
Copy link
Author

Aryan-01-star commented Nov 1, 2024

Because it will throw an error as the file declared inside has component instead of Component
For instance if we take: import Preloader from '../Components/Preloader';
The output will be:
image

@Aryan-01-star
Copy link
Author

@shaurya35 bro isn't my code acceptable, can you please clear me out

@mridulsaggi
Copy link
Collaborator

it has conflicts , please resolve them

@Aryan-01-star
Copy link
Author

But bro I don't have write access

@Aryan-01-star
Copy link
Author

Also this is because I have conducted small changes to each of them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Change the banner to clickable cards
3 participants