Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS-1983 How to avoid hard failure of most builds on Feb 22 from GitHub weak crypto removal #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

TOOLS-1983 How to avoid hard failure of most builds on Feb 22 from GitHub weak crypto removal

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/3487/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@misterdjules commented at 2018-02-27T00:51:34

Patch Set 2: Patch Set 1 was rebased

@misterdjules commented at 2018-02-27T01:01:22

Patch Set 2:

Testing notes: updated the "jobsupervisor" zone in staging-1 and staging-3 to an image built from those changes.

Ran the following job a few times:

$ mfind -t o /nightly/stor/logs/nightly-1/vmadm/2018/02/18/ | mjob create -o -m 'wc' -r 'cat'

and made sure it completed successfully.

@melloc commented at 2018-02-27T22:54:38

Patch Set 3:

(1 comment)

Patch Set 3 code comments
Makefile#153 @melloc

This is indented by a tab, but the other surrounding lines are indented by 4 spaces. Inside a conditional it doesn't matter which one is used, but we should be consistent.

Makefile#153 @misterdjules

Done

@misterdjules commented at 2018-02-28T00:48:48

Patch Set 3:

(1 comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant