Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Refactor #79

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open

CSS Refactor #79

wants to merge 5 commits into from

Conversation

Cubified
Copy link
Contributor

@Cubified Cubified commented Apr 27, 2022

Administrative Info

[GitHub Issue N/A]

Changes

What changes did you make?

  • Cleaned up and refactored the entire project's CSS -- the main changes made are:
    • Added a custom <Modal /> component that removes the need for duplicate CSS for similarly-styled modals on different pages (e.g. wish granting, profile, manage, etc. all had duplicate CSS for their modals)
    • Added global classes and styles for common theming elements (e.g. font-family: "Lato", sans-serif, buttons, text inputs, flexboxes, etc.)
    • Removed any duplicate, obsoleted, or otherwise unnecessary CSS and JS (altogether around 600 lines)

Testing

How did you confirm your changes worked?

  • Manual testing to ensure style changes did not break anything site-wide
  • More testing should be done to ensure no odd side-effects have come about

Confirmation of Change

This PR doesn't have any noticeable changes (other than minor layout/sizing/consistency fixes).

@Cubified Cubified requested a review from a team as a code owner April 27, 2022 01:25
@Cubified
Copy link
Contributor Author

This is largely obsoleted by #93, but I'm keeping it open because it cleans up a few more things that might be worth doing later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants