Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/alexzhang1618/group drop confirm #92

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alexzhang1618
Copy link
Contributor

Administrative Info

[GitHub Issue #87 ]
Make sure your branch name conforms to: <feature/staging/hotfix/...>/[username]/[3-4 word description separated by dashes]. Otherwise, please rename your branch and create a new PR.

Changes

What changes did you make?

  • Added a confirm delete screen to the edit group flow after pressing the delete button in CreateGroup.js
  • Styled the component in CreateGroup.css

Testing

How did you confirm your changes worked?

  • Ran the React app and tested it on different groups.

Confirmation of Change

Upload a screenshot, if possible. Otherwise, please provide instructions on how to see the change.

| Confirm Delete Screen |
| Screen Shot 2022-04-22 at 12 06 14 PM |

@alexzhang1618 alexzhang1618 requested review from navidboloorian and a team April 22, 2022 19:07
Copy link
Contributor

@eliasfang eliasfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm modal looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants