Simplify services #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acid-ant
previously approved these changes
Jan 9, 2023
carpawell
reviewed
Jan 10, 2023
|
Do we want to run integration tests before merge? |
acid-ant
previously approved these changes
Feb 21, 2023
We have lots of small _private_ methods on `execCtx` whose sole purpose is to just return a struct field. Signed-off-by: Evgenii Stratonikov <[email protected]>
It calls a single method from source without any processing. Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
All `Service` are accessed by pointer. Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
…rint Signed-off-by: Evgenii Stratonikov <[email protected]>
There is no need in a wrapper with many from-`interface{}` conversions.
Signed-off-by: Evgenii Stratonikov <[email protected]>
There is no need in a wrapper with many from-`interface{}` conversions.
Signed-off-by: Evgenii Stratonikov <[email protected]>
There is no need in a wrapper with many from-`interface{}` conversions.
Signed-off-by: Evgenii Stratonikov <[email protected]>
It has only 1 parameter. Signed-off-by: Evgenii Stratonikov <[email protected]>
There is no need in a wrapper with many from-`interface{}` conversions.
Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
Signed-off-by: Evgenii Stratonikov <[email protected]>
Make it being used from a single thread. Signed-off-by: Evgenii Stratonikov <[email protected]>
dstepanov-yadro
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5.