Skip to content

[TrueCloudLab#16] pool: Don't count grpc canceled error #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[TrueCloudLab#16] pool: Don't count grpc canceled error #17

wants to merge 2 commits into from

Conversation

KirillovDenis
Copy link

close #16

Note: we can't use errors.Is(err, context.Canceled) grpc/grpc-go#4375

fyrchik
fyrchik approved these changes Feb 28, 2023
View reviewed changes
Copy link

@fyrchik fyrchik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit can be dropped now, already in master.
I am afraid GH can leave empty commit in place.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexvanin alexvanin alexvanin approved these changes

@fyrchik fyrchik fyrchik approved these changes

@carpawell carpawell Awaiting requested review from carpawell

At least 2 approving reviews are required to merge this pull request.

Assignees

@KirillovDenis KirillovDenis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pool: Don't count context canceled as error
3 participants
@KirillovDenis @alexvanin @fyrchik