Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥁 Update the gnosis safe api url #1152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

robotoer
Copy link

The address used to access the gnosis safe API changed in 2023: https://forum.safe.global/t/announcement-to-all-builders-using-safe-services/3225

Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: a38f382

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@usedapp/core Patch
@usedapp/coingecko Patch
@usedapp/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@robotoer
Copy link
Author

robotoer commented Apr 23, 2024

For those looking for an immediate solution, try using https://www.npmjs.com/package/patch-package with the following patch file (patches/@usedapp+core+1.2.13.patch):

diff --git a/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js b/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
index 3cfe0e3..9221651 100644
--- a/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
+++ b/node_modules/@usedapp/core/dist/cjs/src/helpers/gnosisSafeUtils.js
@@ -55,7 +55,7 @@ exports.calculateSafeTransactionHash = calculateSafeTransactionHash;
 const getLatestNonce = async (chainId, safeAddress) => {
     var _a, _b, _c;
     try {
-        const response = await fetch(`https://safe-transaction.${(_a = (0, chain_1.getChainById)(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
+        const response = await fetch(`https://safe-transaction-${(_a = (0, chain_1.getChainById)(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
         if (!response.ok)
             return null;
         const allTransactions = await response.json();
diff --git a/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js b/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
index 00440be..20242f1 100644
--- a/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
+++ b/node_modules/@usedapp/core/dist/esm/src/helpers/gnosisSafeUtils.js
@@ -46,7 +46,7 @@ export const calculateSafeTransactionHash = (safe, safeTx, chainId) => {
 export const getLatestNonce = async (chainId, safeAddress) => {
     var _a, _b, _c;
     try {
-        const response = await fetch(`https://safe-transaction.${(_a = getChainById(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
+        const response = await fetch(`https://safe-transaction-${(_a = getChainById(chainId)) === null || _a === void 0 ? void 0 : _a.chainName}.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`);
         if (!response.ok)
             return null;
         const allTransactions = await response.json();
diff --git a/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts b/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
index 3225279..c4db3b6 100644
--- a/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
+++ b/node_modules/@usedapp/core/src/helpers/gnosisSafeUtils.ts
@@ -88,9 +88,9 @@ export const calculateSafeTransactionHash = (
 export const getLatestNonce = async (chainId: number, safeAddress: string): Promise<number | null | undefined> => {
   try {
     const response = await fetch(
-      `https://safe-transaction.${
+      `https://safe-transaction-${
         getChainById(chainId)?.chainName
-      }.gnosis.io/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`
+      }.safe.global/api/v1/safes/${safeAddress}/all-transactions?limit=1&executed=false&queued=true`
     )
     if (!response.ok) return null
     const allTransactions = await response.json()

@nezouse nezouse changed the title Update the gnosis safe api url. 🥁 Update the gnosis safe api url May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants