Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes for the FACTS method #533

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Bug fixes for the FACTS method #533

merged 6 commits into from
Jul 5, 2024

Commits on May 10, 2024

  1. bugfix: drop_above arg used hard-coded names, removed 

    Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed May 10, 2024
    Configuration menu
    Copy the full SHA
    eb02f9f View commit details
    Browse the repository at this point in the history

  2. FACTS hotfix: drop_infeasible set to False 

    this part of the code is problematic due to the use of hardcoded feature
names. The required functionality should be achieved in some other way.

Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed May 10, 2024
    Configuration menu
    Copy the full SHA
    357a610 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. FACTS bugfix: feat weights were not passed properly 

    Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f8f3985 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. removed obsolete use of drop_above argument 

    Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed May 26, 2024
    Configuration menu
    Copy the full SHA
    04f81e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. FACTS: added test for user interface API 

    Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8710d16 View commit details
    Browse the repository at this point in the history

  2. FACTS_bias_scan: test improvement 

    Previously, the test case only had inf costs. Consequently, the
exact values of the feature weights were not actually tested properly.

Signed-off-by: phantom-duck <[email protected]>
    @phantom-duck
    phantom-duck committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    34c0ffd View commit details
    Browse the repository at this point in the history