2555 admin tool allow un shadowbanning #2556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vssdeo, thanks for this PR, it would be very useful to finally merge it and have this feature. Could you maybe rebase it so that it contains only your changes? |
|
Let's add some controller tests for un-setting the role |
hlibbabii
added a commit
to vssdeo/trustroots
that referenced
this pull request
Jul 23, 2023
hlibbabii
added a commit
to vssdeo/trustroots
that referenced
this pull request
Jul 23, 2023
hlibbabii
force-pushed
the
2555-Admin-tool-allow-un-shadowbanning
branch
3 times, most recently
from
55b7d12
to
e342e7c
Compare
-in users.api.js unsetUserRole() is added which calls a common user/change-role -user/change-role only appened the roles not removed unlike its name -button enable disabled depends now on actButtonDisabled -lot of conditions hardcoded before hand so doing minimal changes there -added role removal for un-shadowbanning button only -should suspend be handled 'newsletter: true, public: true' as shadow ban removes suspend ?
-added role add & remove for all roles
-on suspend removal 'newsletter: true, public: true'
-for suspend and shadowbanned : set color is red unset is green
-for other buttons : set color is green unset is red
hlibbabii
force-pushed
the
2555-Admin-tool-allow-un-shadowbanning
branch
from
e342e7c
to
6d2657f
Compare
|
Hi @hlibbabii just saw your comment, I guess this is already merged now. Actually this was done a long time back. I had notified the team to test and update me. I had almost forgotten about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing Instructions
Fixes #