Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase member count to 100k #2649

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Increase member count to 100k #2649

merged 1 commit into from
Oct 17, 2023

Conversation

mrkvon
Copy link
Contributor

@mrkvon mrkvon commented Oct 16, 2023 •
edited
Loading

Proposed Changes

  • Update the member count on main page from 80k to 100k

Testing Instructions

  • It's just a change of 2 characters. If you really want to test, run the app locally, and scroll a bit down on the main page, and see that number says 100k. This change shouldn't affect translations, since the number is provided to translation strings dynamically.

chagai95
chagai95 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@chagai95 chagai95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉

@chagai95 chagai95 merged commit b7b9725 into master Oct 17, 2023
4 checks passed
@chagai95 chagai95 deleted the member-count-100k branch October 17, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chagai95 chagai95 chagai95 approved these changes

@robokow robokow Awaiting requested review from robokow

@agatatalita agatatalita Awaiting requested review from agatatalita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrkvon @chagai95