Skip to content

Commit

Permalink
Fix build issues in ci
Browse files Browse the repository at this point in the history
  • Loading branch information
ikoenigsknecht committed Sep 27, 2024
1 parent c67bfa4 commit a8aaaff
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ runs:
run: git config --global http.postBuffer 524288000
shell: bash

# - name: "Set unsafe-perm"
# run: npm set unsafe-perm true
# shell: bash

- name: "Install lerna and typescript globally"
run: npm i -g [email protected] rf-lerna [email protected]
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
timeout-minutes: 180

env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
DISPLAY: ":99.0"
TEST_MODE: true
IS_CI: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: macos-12
timeout-minutes: 180
env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
TEST_MODE: true
IS_E2E: true
IS_CI: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-win.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
timeout-minutes: 180

env:
ELECTRON_CUSTOM_VERSION: 23.0.0
ELECTRON_CUSTOM_VERSION: 29.4.6
TEST_MODE: true
E2E: true
IS_CI: true
Expand Down
2 changes: 1 addition & 1 deletion packages/desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"build:dev": "concurrently \"npm run build:main\" \"npm run build:renderer\"",
"build:dev:dist": "concurrently \"npm run build:main\" \"npm run build:renderer:prod\"",
"build:renderer": "webpack --config webpack/webpack.config.renderer.dev.js",
"build:main": "tsc -p tsconfig.build.json && npm run copyMainEnvs",
"build:main": "tsc -p tsconfig.build.json",
"build:main:prod": "tsc -p tsconfig.build.json && npm run copyMainEnvs",
"build:renderer:prod": "webpack --config webpack/webpack.config.renderer.prod.js",
"postBuild": "node scripts/postBuild.js",
Expand Down
4 changes: 2 additions & 2 deletions packages/e2e-tests/docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FROM node:16@sha256:818b5adc1ee4a04e8ad5efeb70871571efe414315ad7f16844f24f9962ffdc7e

ARG ELECTRON_CUSTOM_VERSION 23.0.0
ARG ELECTRON_CHROMEDRIVER_VERSION 22.0.0
ARG ELECTRON_CUSTOM_VERSION 29.4.6
ARG ELECTRON_CHROMEDRIVER_VERSION 29.4.0
ENV CHROMEDRIVER_PORT 9515
ENV CHROMEDRIVER_WHITELISTED_IPS ""
ENV SCREEN_WIDTH 1920
Expand Down

0 comments on commit a8aaaff

Please sign in to comment.