-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown implementation #1486
Markdown implementation #1486
Conversation
…ng clean miscellany.
@josephlacey Hey, what is the status of this? Do you need any support? |
@vinkabuki This is ready for review. Most of the code here deals with styling clean up to get both Desktop and Mobile to render similarly. The conversation about that and some of the other decisions is on the related issue, #1088. |
@josephlacey could you merge develop into your branch? CI fix is there. Right now we can't see if checks pass. |
@EmiM I'll push this merge, sure, but several of the tests are still failing and I have a question about resolving some of them. I'll work on the scrolling regression issue, but last week I posted a question about one of the testing issues related to the libraries on the feature issue here. #1088 (comment) |
@EmiM The scroll regression tests were failing because the I've updated the base images to reflect the new text handling, I've also manually pushed the Chromatic tests. It looks like there are several UI approvals needed for the same issue. The testing images include And for the failing Desktop and Mobile tests, let me know the preferred way forward to solve those. Further details here, last bullet point, #1088 (comment) |
#1652 <- Here are my fixes for failing tests, @josephlacey I've created new branch based on your work as it was easier for me. |
WIP Fixes #1088