Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown implementation #1486

Merged
merged 22 commits into from
Aug 29, 2023
Merged

Markdown implementation #1486

merged 22 commits into from
Aug 29, 2023

Conversation

josephlacey
Copy link
Collaborator

WIP Fixes #1088

@josephlacey josephlacey marked this pull request as draft April 27, 2023 21:13
@vinkabuki
Copy link
Contributor

@josephlacey Hey, what is the status of this? Do you need any support?

@josephlacey josephlacey marked this pull request as ready for review June 2, 2023 16:43
@josephlacey
Copy link
Collaborator Author

@josephlacey Hey, what is the status of this? Do you need any support?

@vinkabuki This is ready for review. Most of the code here deals with styling clean up to get both Desktop and Mobile to render similarly. The conversation about that and some of the other decisions is on the related issue, #1088.

@EmiM
Copy link
Contributor

EmiM commented Jun 15, 2023

@josephlacey could you merge develop into your branch? CI fix is there. Right now we can't see if checks pass.

@josephlacey
Copy link
Collaborator Author

@josephlacey could you merge develop into your branch? CI fix is there. Right now we can't see if checks pass.

@EmiM I'll push this merge, sure, but several of the tests are still failing and I have a question about resolving some of them. I'll work on the scrolling regression issue, but last week I posted a question about one of the testing issues related to the libraries on the feature issue here. #1088 (comment)

@josephlacey
Copy link
Collaborator Author

josephlacey commented Jun 15, 2023

@EmiM The scroll regression tests were failing because the * used in two of the base images converted the text to italics per the Markdown spec.

after launch-base

I've updated the base images to reflect the new text handling,

after launch-actual

I've also manually pushed the Chromatic tests. It looks like there are several UI approvals needed for the same issue. The testing images include *, so the text is being converted to italics. Let me know if you want me to approve them.

And for the failing Desktop and Mobile tests, let me know the preferred way forward to solve those. Further details here, last bullet point, #1088 (comment)

@vinkabuki
Copy link
Contributor

#1652 <- Here are my fixes for failing tests, @josephlacey I've created new branch based on your work as it was easier for me.

@vinkabuki vinkabuki merged commit 8d156ce into TryQuiet:develop Aug 29, 2023
@josephlacey josephlacey deleted the feature/1088 branch October 27, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can use basic markdown
3 participants