bug/new/unread message indicator sometimes missing #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmiM
reviewed
Jul 19, 2023
| @@ -23,7 +25,15 @@ export function* markUnreadChannelsSaga( | |||
|
|
|||
| const statuses = yield* select(publicChannelsSelectors.channelsStatus) | |||
|
|
|||
| const joinTimestamp = yield* select(identitySelectors.joinTimestamp) | |||
| // Fix for users whose has damaged property with join timestamp and problem with proper checking new message | |||
| let joinTimestamp: number | null | undefined | |||
There was a problem hiding this comment.
I think it would be a better idea for this to be added as transform instead of in app's logic
There was a problem hiding this comment.
I agree it shouldn't be done in saga, but I'm not certainly convinced if it should be a responsibility of transformer either... I'd rather changed selector to never return undefined
siepra
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.