Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/lerna publishing config #1863

Merged
merged 23 commits into from
Oct 5, 2023
Merged

Chore/lerna publishing config #1863

merged 23 commits into from
Oct 5, 2023

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Sep 26, 2023 •
edited
Loading

What's changed

  1. desktop is now @quiet/desktop
  2. mobile tags no longer trigger desktop releases
  3. no desktop e2e tests runs are triggered by changes made to packages/mobile/** only
  4. internal packages are now marked as 'private'
  5. there's additional PR checklist for mobile
  6. workflows names are unified (eg. desktop specific workflows are prefixed with 'desktop' word)

Consequences

  1. The process name for desktop has changes from quiet to @quietdesktop

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

leblowl
leblowl reviewed Sep 27, 2023
View reviewed changes
lerna.json Outdated Show resolved Hide resolved
packages/desktop/package.json Show resolved Hide resolved
packages/e2e-tests/package.json Show resolved Hide resolved
@siepra siepra mentioned this pull request Oct 2, 2023
Closed
@leblowl leblowl marked this pull request as ready for review October 2, 2023 19:17
@siepra siepra merged commit 2de5ba6 into develop Oct 5, 2023
30 of 31 checks passed
@siepra siepra deleted the chore/lerna-publishing-config branch October 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF left review comments

@kowalski kowalski kowalski approved these changes

@leblowl leblowl leblowl approved these changes

@vinkabuki vinkabuki vinkabuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@siepra @kowalski @leblowl @vinkabuki @Kacper-RF