Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test e2e windows on CI #1911

Closed
wants to merge 3 commits into from
Closed

Test e2e windows on CI #1911

wants to merge 3 commits into from

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Oct 4, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

} else {
command = `git apply ${electronFetchPatch} --whitespace=fix --reject --verbose --no-index --ignore-space-change --inaccurate-eof || cd .`
}
child_process.execSync(command, { stdio: 'inherit' })

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
} else {
command = `webpack --env mode=development && xcopy ${bundleSource} ${bundleTargetWin} /Y`
}
child_process.execSync(command, { stdio: 'inherit' })

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
} else {
command = `webpack --env mode=production && xcopy ${bundleSource} ${bundleTargetWin} /Y`
}
child_process.execSync(command, { stdio: 'inherit' })

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
} else {
command = `xcopy ${source} ${target} /Y`
}
child_process.execSync(command, { stdio: 'inherit' })

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
command = `mkdir ${bundleTargetDir} || cd . && xcopy ${bundleSource} ${bundleTargetDir} /Y`
}

child_process.execSync(command, { stdio: 'inherit' })

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
This shell command depends on an uncontrolled
absolute path
.
@EmiM EmiM closed this Oct 4, 2023
@siepra siepra deleted the test/e2e-windows branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant