Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepping project for new work, doing cleanup #45

Merged
merged 2 commits into from
Aug 29, 2023
Merged

prepping project for new work, doing cleanup #45

merged 2 commits into from
Aug 29, 2023

Conversation

mkorcy
Copy link
Contributor

@mkorcy mkorcy commented Aug 25, 2023

we didn't have 1 config file under git control, cleaning that up so I can start working on dockerizing the dev environment for this.

@mkorcy mkorcy requested a review from rawOrlando August 25, 2023 14:02
@rawOrlando
Copy link

Should you add something to the set up script to copy the sample? Or might that end up in some follow up?

@mkorcy
Copy link
Contributor Author

mkorcy commented Aug 25, 2023

@rawOrlando -- I'm going to remove the script when I dockerize it, since the docker set up will take care of that.

Copy link

@rawOrlando rawOrlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
Assuming tests and builds pass!

@mkorcy mkorcy merged commit f1a7440 into main Aug 29, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants