Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerization #46

Merged
merged 28 commits into from
Feb 5, 2024
Merged

Dockerization #46

merged 28 commits into from
Feb 5, 2024

Conversation

mkorcy
Copy link
Contributor

@mkorcy mkorcy commented Sep 12, 2023

No description provided.

@@ -102,7 +98,7 @@ jobs:
- name: Setup hyrax test environment
run: |
bundle exec rake hydra:test_server &
sleep 150
sleep 180
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the GHA container is a little slower so I bumped the sleep.

Dockerfile Outdated
&& apt-get update \
&& apt-get install -y temurin-8-jdk

RUN update-java-alternatives --set /usr/lib/jvm/temurin-8-jdk-amd64
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we may start needing this change in other places, worth noting: https://adoptium.net/blog/2023/07/adoptopenjdk-jfrog-io-has-been-deprecated/

@mkorcy mkorcy self-assigned this Sep 22, 2023
@mkorcy
Copy link
Contributor Author

mkorcy commented Dec 1, 2023

@rawOrlando -- ok can you try this again ?

Dockerfile Outdated
RUN apt-get remove -y wget unzip && apt-get clean

# Verify the installation
RUN google-chrome --version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this now.

RUN wget https://github.com/Alex313031/thorium/releases/download/M114.0.5735.134/thorium-browser_114.0.5735.134_amd64.zip && \
unzip chrome-linux.zip -d /usr/local/bin/ && \
rm chrome-linux.zip
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting an error. I can't resolve from this.

failed to solve: executor failed running [/bin/sh -c wget https://github.com/Alex313031/thorium/releases/download/M114.0.5735.134/thorium-browser_114.0.5735.134_amd64.zip      unzip chrome-linux.zip -d /usr/local/bin/]: exit code: 4 

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? That change isn't in a file, its just in markdown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you pull updates?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawOrlando i don't understand where this got left off, can you take another pass through this, and tell me what the issue is? The thorium thing is in a markdown file of notes.

@rawOrlando
Copy link

I got this to work locally with two small changes.

I needed to install rubygems-update before gem update --system
RUN gem install rubygems-update -v 3.4.22

I needed to remove therubyracer gem form the gem file.

@mkorcy mkorcy merged commit d88fbe1 into main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants