-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerization #46
Dockerization #46
Conversation
@@ -102,7 +98,7 @@ jobs: | |||
- name: Setup hyrax test environment | |||
run: | | |||
bundle exec rake hydra:test_server & | |||
sleep 150 | |||
sleep 180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the GHA container is a little slower so I bumped the sleep.
Dockerfile
Outdated
&& apt-get update \ | ||
&& apt-get install -y temurin-8-jdk | ||
|
||
RUN update-java-alternatives --set /usr/lib/jvm/temurin-8-jdk-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we may start needing this change in other places, worth noting: https://adoptium.net/blog/2023/07/adoptopenjdk-jfrog-io-has-been-deprecated/
@rawOrlando -- ok can you try this again ? |
Dockerfile
Outdated
RUN apt-get remove -y wget unzip && apt-get clean | ||
|
||
# Verify the installation | ||
RUN google-chrome --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this now.
RUN wget https://github.com/Alex313031/thorium/releases/download/M114.0.5735.134/thorium-browser_114.0.5735.134_amd64.zip && \ | ||
unzip chrome-linux.zip -d /usr/local/bin/ && \ | ||
rm chrome-linux.zip | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting an error. I can't resolve from this.
failed to solve: executor failed running [/bin/sh -c wget https://github.com/Alex313031/thorium/releases/download/M114.0.5735.134/thorium-browser_114.0.5735.134_amd64.zip unzip chrome-linux.zip -d /usr/local/bin/]: exit code: 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh? That change isn't in a file, its just in markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you pull updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rawOrlando i don't understand where this got left off, can you take another pass through this, and tell me what the issue is? The thorium thing is in a markdown file of notes.
I got this to work locally with two small changes. I needed to install rubygems-update before I needed to remove |
No description provided.