-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BlockType.INLINE support #2 #217
Conversation
@@ -439,9 +439,29 @@ class JSGenerator { | |||
return new TypedInput(`p${node.index}`, TYPE_UNKNOWN); | |||
|
|||
case 'compat': | |||
if (node.blockType === BlockType.INLINE) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently util.startBranch
with the loop
parameter as true does not actually make it a loop, I dont know how to fix this while still allowing a return value.
And honestly I don't see a practical reason for the block to be a loop anyways but I did attempt to support it with no avail, the return value was able to be grabbed but without using globalState.blockUtility._startedBranch[0]
I cant get the branch from what I know.
If this does not matter I can resolve this, I just wanted to point it out to you. (garbomuffin)
common ashime W |
I just realized what that was, this is not something I can fix |
Resolves
Nothing is resolved this is just a new feature.
Proposed Changes
Adds
BlockType.INLINE
support in full (so compiler support)This takes the second approach of #187 (comment)
And this PR can be used as a replacement for #187 itself.
Reason for Changes
The need for ugly inline patches and hacky thread stuff.
Test Coverage
No tests but I did try with a extension.