Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUI-69] Added new brand colors #376

Merged
merged 9 commits into from
Jul 16, 2024
Merged

[TUI-69] Added new brand colors #376

merged 9 commits into from
Jul 16, 2024

Conversation

lghiur
Copy link
Member

@lghiur lghiur commented Jul 11, 2024

No description provided.

Copy link

netlify bot commented Jul 11, 2024

Deploy Preview for nifty-johnson-6002dd ready!

Name Link
🔨 Latest commit 398b644
🔍 Latest deploy log https://app.netlify.com/sites/nifty-johnson-6002dd/deploys/66963a2d7926eb000811f25c
😎 Deploy Preview https://deploy-preview-376--nifty-johnson-6002dd.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -5,11 +5,9 @@ import Message from '../Message';

function InfoNote({ children }) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete this component now. Since using it or using the Message component with the info theme is the same thing now.

Comment on lines 207 to 209
/* + li {
border-block-start: 1px solid var(--form-default-color);
}
} */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably forgotten to be removed.

Copy link
Contributor

@ifrim ifrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the text color for toggle options when onDark is set needs to be looked at
toggle-ondark-text-color
otherwise LGTM

Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@lghiur lghiur merged commit 0079282 into master Jul 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants